psp-7099 prevent infinite refresh loop of acq files when user is not … #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-7099
branch
from
f5cbd9a to
21ec169
Compare
|
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3548 +/- ##
===========================================
+ Coverage 63.05% 74.35% +11.30%
===========================================
Files 471 899 +428
Lines 15040 18514 +3474
Branches 1019 5217 +4198
===========================================
+ Hits 9483 13766 +4283
+ Misses 5307 4748 -559
+ Partials 250 0 -250
Flags with carried forward coverage won't be shown. Click here to find out more.
|
asanchezr
reviewed
Oct 27, 2023
Comment on lines
+165
to
+170
| {error && ( | ||
| <b> | ||
| Failed to load Acquisition File. Check the detailed error in the top right for | ||
| more details. | ||
| </b> | ||
| )} |
There was a problem hiding this comment.
nit: please add unit tests to cover this new logic
asanchezr
approved these changes
Oct 27, 2023
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-7099
branch
from
6ece754 to
1e126ac
Compare
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-7099
branch
from
1e126ac to
79535fd
Compare
|
✅ No secrets were detected in the code. |
…authorized or file does not exist.
devinleighsmith
force-pushed
the
psp-7099
branch
from
79535fd to
051aa33
Compare
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…authorized or file does not exist.